[tpop3d-discuss][PATCH]: poll for tpop3d

Arkadiusz Miskiewicz arekm at pld-linux.org
Sun, 25 Jun 2006 22:30:50 +0200


On Saturday 24 June 2006 19:46, Chris Lightfoot wrote:
> On Thu, Jun 22, 2006 at 08:28:04PM +0200, Arkadiusz Miskiewicz wrote:

> > > applied in CVS, with a poll(2) wrapper and autoconf test.
> > > Please test ;-)
> >
> > Version from cvs works for me.  There is one thing in my patch which
> > could be nicer - match existing code like using xcalloc and xfree inste=
ad
> > of malloc and free.
> >
> > ps. another patch for consideration:
> > http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/tpop3d-disable-dotfile-=
lo
> >cking.patch by heretyk@pld-linux.org
>
> Now also applied in CVS.

Please apply this one, too:
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/tpop3d-poll.patch?rev=3D1.10

It fixes:
=2D use poll when available (right now we were always using select fallback)
=2D fix for case when revents contain more than one event (I guess that's=20
possible)
=2D set descriptors to -1 so kernel can skip them when doing poll()
=2D the second parameter of poll is highest possible index in an array (no =
need=20
to +1)

=2D-=20
Arkadiusz Mi=B6kiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/