iftop-users

iftop-users@lists.beasts.org

195 discussions

[PATCH] unlimited text output
by Roman Hoog Antink 17 Mar '14

17 Mar '14

Hi Paul Please consider this patch for 1.0pre5. It allows unlimited number of lines in text output, using "iftop -t -L 0". Thanks to Yan Chen for suggesting this tiny improvement. Cheers, Roman

1 0

Patches to fix some bugs with 10gbit cards
by Hans Fugal 07 Mar '14

07 Mar '14

[PATCH 1/3] Avoid 32-bit overflow for rates when calculating bar length Avoid 32-bit overflow by using double instead of int. uint64_t would be another option but these are only ever used in conjunction with floats. (float was also an option) --- ui.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui.c b/ui.c index 57ca6c0..8a3b9d0 100644 --- a/ui.c +++ b/ui.c @@ -71,7 +71,8 @@ int dontshowdisplay = 0; /* Barchart scales. */ static struct { - int max, interval; + double max; + int interval; } scale[] = { { 64000, 10 }, /* 64 kbit/s */ { 128000, 10 }, @@ -105,7 +106,7 @@ static float get_max_bandwidth() { } /* rate in bits */ -static int get_bar_length(const int rate) { +static int get_bar_length(const double rate) { float l; if (rate <= 0) return 0; [PATCH 2/3] scale[] up to tbit Extend the scale[] array up to terabit. 10gbit is not uncommon, 100gbit 40 and 100 gbit are coming, 400 gbit and terabit are future possibilities. --- ui.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/ui.c b/ui.c index 8a3b9d0..d1500ad 100644 --- a/ui.c +++ b/ui.c @@ -74,13 +74,16 @@ static struct { double max; int interval; } scale[] = { - { 64000, 10 }, /* 64 kbit/s */ - { 128000, 10 }, - { 256000, 10 }, - { 1000000, 10 }, /* 1 Mbit/s */ - { 10000000, 10 }, - { 100000000, 100 }, - { 1000000000, 100 } /* 1 Gbit/s */ + { 64000, 10 }, /* 64 kbit/s */ + { 128000, 10 }, + { 256000, 10 }, + { 1000000, 10 }, /* 1 Mbit/s */ + { 10000000, 10 }, + { 100000000, 100 }, + { 1000000000, 100 }, /* 1 Gbit/s */ + { 10000000000, 100 }, + { 100000000000, 100 }, + { 1000000000000, 100 }, /* 1 Tbit/s */ }; static int rateidx = 0, wantbiggerrate; [PATCH 3/3] rateidx_init fix When calculating the first rateidx, we were overshooting to the next scale. Fix that. --- ui.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui.c b/ui.c index d1500ad..15624bf 100644 --- a/ui.c +++ b/ui.c @@ -116,7 +116,8 @@ static int get_bar_length(const double rate) { if (rate > scale[rateidx].max) { wantbiggerrate = 1; if(! rateidx_init) { - while(rate > scale[rateidx_init++].max) { + while(rate > scale[rateidx_init].max) { + rateidx_init++; } rateidx = rateidx_init; }

1 0

[PATCH] Display MAC Address in better format
by Xiaoguang Sun 03 Mar '14

03 Mar '14

Before this patch: root@57:~/iftop-1.0pre4# ./iftop interface: eth0 IP address is: 192.168.1.57 MAC address is: ffffffbc:ffffffee:7b:ffffffdb:0b:ffffffd4 With this patch root@57:~/iftop-1.0pre4# ./iftop interface: eth0 IP address is: 192.168.1.57 MAC address is: bc:ee:7b:db:0b:d4

1 0

the CPU usage is 100% when shell or perl script run iftop
by Darren (Chenji) Xu 13 Feb '14

13 Feb '14

Hi Paul, Do you encounter this issue? I haven't found this issue when I used tcpdump. I think it maybe a iftop bug. Thanks, Darren ------- PS: #!/bin/bash #tcpdump -nnlqp tcp & iftop -nt &

1 2

[PATCH] Fix MAC address formatting
by Zev Weiss 07 Feb '14

07 Feb '14

Hi, Running iftop-1.0pre4 I noticed my MAC address getting printed with some bytes (the "negative" ones) sign-extended into 32 bits (i.e. with "ffffff" prefixed). The below patch restores more a conventional-looking format. Thanks, Zev Weiss diff -Naur iftop-1.0pre4.orig/iftop.c iftop-1.0pre4/iftop.c --- iftop-1.0pre4.orig/iftop.c 2014-01-19 12:21:19.000000000 -0800 +++ iftop-1.0pre4/iftop.c 2014-02-07 13:26:15.669698968 -0800 @@ -713,7 +713,7 @@ if(have_hw_addr) { fprintf(stderr, "MAC address is:"); for (i = 0; i < 6; ++i) - fprintf(stderr, "%c%02x", i ? ':' : ' ', (unsigned int)if_hw_addr[i]); + fprintf(stderr, "%c%02hhx", i ? ':' : ' ', if_hw_addr[i]); fprintf(stderr, "\n"); }

2 1

iftop 1.0pre4
by Paul Warren 22 Jan '14

22 Jan '14

A bit later than planned, iftop 1.0pre4 is now released. Unless someone tells me that this is more broken than pre3, I'll release it as 1.0 in a week or so. http://www.ex-parrot.com/~pdw/iftop/download/iftop-1.0pre4.tar.gz The changes have been exclusively to address compile time issues, and documentation fixes. Paul

2 1

1.0pre3 released
by Paul Warren 20 Jan '14

20 Jan '14

Much later than intended, I have finally produced a new release of iftop: 1.0pre3. There were quite a few issues thrown up in pre2, hence a further pre-release. This release is primarily bug fixes and build issues, but I've also added the extremely long-standing text mode output patch, which the mailing list ate when it was originally submitted in 2007. Thanks to everyone who has contributed patches. Please let me know if you have any issues with this release, as if not I'll be calling it 1.0. The release is here: http://www.ex-parrot.com/~pdw/iftop/download/iftop-1.0pre3.tar.gz Happy New Year! Paul

3 5

libtinfo compatibility patch
by justin 20 Jan '14

20 Jan '14

Hi, if libncurses if build with split out libtinfo as done in many distros we need to link against both libs. Please find attached a patch which utilizes pkg-conifg to detect the correct libs to link with. If that fails it falls back to the original configure structure. Regards, Justin

1 0

ancient text output patch ported to latest version
by Roman Hoog Antink 01 Jan '14

01 Jan '14

Hi there [reposted with compressed attachment so no moderation needed] Back in 2007 Patrik Bless, a former colleague, wrote the attached patch, which was never committed to the repo, because his request got stuck in the moderated forum. The patch adds a text output feature, allowing machine parsing of output or redirecting it to a file, as requested in this mailing list lately by Shannon Rodrigues. http://lists.beasts.org/pipermail/iftop-users/2012-September/000369.html Please consider adding it before version 1.0 comes out. Can someone explain, why the CVS repo has no tags for the 0.18 and 0.19 releases? Kind regards, Roman -- Roman Hoog Antink Dipl. Ing. ETH Senior Security Engineer Open Systems AG Räffelstrasse 29 CH-8045 Zürich t: +41 44 455 74 00 f: +41 44 455 74 01 rha(a)open.ch http://www.open.ch

3 5

CPU use bug?
by Alex Page 20 Nov '13

20 Nov '13

Hello, I am seeing strange behavior recently in iftop on Ubuntu (x64, 12.04 and 13.10). With Port Display disabled, iftop simply uses more CPU than normal (say, 20% instead of a negligible amount). Then, when Port Display is enabled, CPU use goes straight to 100% and iftop becomes unresponsive. This behavior started sometime in the last few months, and occurs on 2 of the 4 Ubuntu machines that I've tested it on. I compiled iftop 0.17 and 1.0-pre2 from source and observed the same behavior as the precompiled version (1.0-pre2 from the Ubuntu repo) on these computers. I cannot figure out what is unique (other than physical hardware) about the 2 machines that still work, except that they use 3.2 and 3.6 kernels (vs. 3.5 and 3.11 on the machines that don't work). So maybe there's a network driver issue? I checked the version numbers of libc6, libncurses, libpcap, and libtinfo (all the dependencies I know of) and they are the same on 1 of the working machines vs. 1 of the non-working ones. And iftop worked properly on all of these machines until some relatively recent update. So, iftop is completely unusable on at least 2 of my computers. Can anyone recommend further troubleshooting steps that I could take to isolate this problem, preferably without rebooting? Are there any other library versions I should check? Thanks, Alex

2 5

← Newer
1
2
3
4
5
6
7
8
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

iftop-users