iftop-users

iftop-users@lists.beasts.org

195 discussions

Start a nNew thread

False names on IP6 addresses with NXDOMAIN from rDNS
by Stuart Gathman 25 Feb '16

25 Feb '16

It wasn't obvious to me where the fix would be: https://bugzilla.redhat.com/show_bug.cgi?id=1309755

1 0

Simple text output
by philippe＠faure.ca 25 Nov '15

25 Nov '15

5 7

(patch) iftop may ignore IPv6 traffic
by Timo Buhrmester 22 Aug '15

22 Aug '15

I've been running iftop on my home gateway (NetBSD/i386) for a while, and recently realized that it completely ignores the IPv6 traffic going through. The problem is that `handle_ip_packet` ends up throwing away the IPv6 packets when it can't figure out the direction of a packet. Here's what's going on, we're in `handle_ip_packet` and have an IPv6 packet pointed to by `iptr`: | if(hw_dir == 1) { Nope, hardware doesn't tell the direction | } else if(hw_dir == 0) { Nope, see above. | } else if((IP_V(iptr) == 4) && have_ip_addr && ip_addr_match(iptr->ip_src)) { Nope, this isn't IPv4 | } else if((IP_V(iptr) == 4) && have_ip_addr && ip_addr_match(iptr->ip_dst)) { Nope, see above. | } else if((IP_V(iptr) == 6) && have_ip6_addr && ip6_addr_match(&ip6tr->ip6_src)) { Nope, this is IPv6, but `have_ip6_addr` is zero -- we couldn't get an ipv6 interface address because get_addrs_ioctl() is IPv4-specific. getifaddrs() *is* available on NetBSD, so that could be used. But I believe this is unrelated to the problem I am reporting, because on a router, even if we knew our interface address, the traffic going through would usually not carry our interface address. | } else if((IP_V(iptr) == 6) && have_ip6_addr && ip6_addr_match(&ip6tr->ip6_dst)) { Nope, see above. | } else if (IP_V(iptr) == 4 && IN_MULTICAST(iptr->ip_dst.s_addr)) { Nope, this isn't IPv4 | } else if (IP_V(iptr) == 6 && IN6_IS_ADDR_MULTICAST(&ip6tr->ip6_dst)) { Nope, this isn't multicast either | } else if (options.promiscuous_but_choosy) { Nope, not set | } else if((IP_V(iptr) == 4) && (iptr->ip_src.s_addr < iptr->ip_dst.s_addr)) { Nope, this isn't IPv4 | } else if(IP_V(iptr) == 4) { Nope, this isn't IPv4 | } else | return; The IPv6 packet is thus discarded here and is never shown or accounted for. Now, all the last `else if` branch in the above list does is: | assign_addr_pair(&ap, iptr, 0); | direction = 0; which on the first glance should work with IPv6 as well. With the below patch, my IPv6 traffic is now showing. Best regards, Timo Buhrmester --- iftop.c.orig 2015-07-20 19:53:07.000000000 +0200 +++ iftop.c 2015-07-20 19:52:35.000000000 +0200 @@ -327,13 +327,10 @@ assign_addr_pair(&ap, iptr, 1); direction = 0; } - else if(IP_V(iptr) == 4) { + else { /* IPv4 or IPv6 */ assign_addr_pair(&ap, iptr, 0); direction = 0; } - /* Drop other uncertain packages. */ - else - return; } if(IP_V(iptr) == 4 && options.netfilter != 0) {

1 1

about hash_create function
by xuansheng mo 30 May '15

30 May '15

hello: The iftop is very userful while inspecting the flows between hosts. And I want to add some log features in our environment. The functions serv_hash_create and ns_hash_create are allocating and returning a hash: hash_type* ns_hash_create() { hash_type* hash_table; hash_table = xcalloc(hash_table_size, sizeof *hash_table); hash_table->size = hash_table_size; hash_table->compare = &ns_hash_compare; hash_table->hash = &ns_hash_hash; hash_table->delete_key = &ns_hash_delete_key; hash_table->copy_key = &ns_hash_copy_key; hash_initialise(hash_table); return hash_table; } hash_type* serv_hash_create() { hash_type* hash_table; hash_table = xcalloc(hash_table_size, sizeof *hash_table); hash_table->size = hash_table_size; hash_table->compare = &serv_hash_compare; hash_table->hash = &serv_hash_hash; hash_table->delete_key = &serv_hash_delete_key; hash_table->copy_key = &serv_hash_copy_key; hash_initialise(hash_table); return hash_table; } Is the clause " hash_table = xcalloc(hash_table_size, sizeof *hash_table);" a bug? It allocate a hash_type array with hash_table_size items. Should be " hash_table = xcalloc(1, sizeof *hash_table);"? And allocate the hash buckets with " hash_initialise(hash_table);" Thanks.

1 0

Add traffic accounting in PPS; drop short packets
by fred＠fperrin.net 23 Apr '15

23 Apr '15

Hi list, I'm sending the following patches. The first is a one-liner gcc was complaining about; the second add a new feature to do traffic accounting in packet per second rather than bit/s; the third is a fix to handle_ip_packet() which was reading past the end of certain malformed packets. [PATCH 1/4] Silence a warning [PATCH 2/4] Do traffic accounting in pps [PATCH 3/4] Drop packets shorter than sizeof (struct iphdr)

2 4

unsubscribe
by Ali Jawad 23 Apr '15

23 Apr '15

unsubscribe On Thu, Apr 23, 2015 at 12:12 PM, <fred(a)fperrin.net> wrote: > Hi list, > > On my machine, if I generate the following IPv6 flood: > > ip -6 neigh add fe80::1234 dev eth0 lladdr 00:11:22:33:44:55 > nc -6 -u fe80::1234%eth0 1234 < /dev/zero > > The traffic reported by iftop is much less than the reality, as iftop > can't read packets off pcap fast enough. This patch only demonstrate > the problem, I don't intend for it to be applied. I haven't started to > dig into the cause yet. > > > _______________________________________________ > iftop-users mailing list > iftop-users(a)lists.beasts.org > http://lists.beasts.org/mailman/listinfo/iftop-users >

1 0

iftop performance issue
by fred＠fperrin.net 23 Apr '15

23 Apr '15

Hi list, On my machine, if I generate the following IPv6 flood: ip -6 neigh add fe80::1234 dev eth0 lladdr 00:11:22:33:44:55 nc -6 -u fe80::1234%eth0 1234 < /dev/zero The traffic reported by iftop is much less than the reality, as iftop can't read packets off pcap fast enough. This patch only demonstrate the problem, I don't intend for it to be applied. I haven't started to dig into the cause yet.

1 1

how to iftop
by Anilkumar Naik 22 Sep '14

22 Sep '14

Dear All, I like to run iftop in batch mode and capture our LAN mirror port traffic. This can be working very well in interactive mode. I seek your help to achieve following. How to capture hosts download traffic anything more than 100MB(variable) and send a email to Netadmin. Of course I need to write a bit of code to send a email. But at this moment like to know how I run iftop to write inbound hosts list in a file? Thanks for help, A J Naik

1 0

[PATCH] unblock text UI for automated readout
by Roman Hoog Antink 16 Jun '14

16 Jun '14

Hi Please accept the attached patch. It fixes blocking text output (-t) in case iftop is run as subprocess (without ptty). It also contains a few whitespace cleanups in tui.c. Author: Georg Schoelly <ges(a)open.ch> Cheers, Roman PGP key: http://pgp.mit.edu/pks/lookup?search=rha%40open.ch&op=index

1 0

[PATCH] Add colored output to iftop
by David Heidelberger 26 Mar '14

26 Mar '14

Add colored output to iftop. Based on https://github.com/srix/iftopcolor Signed-off-by: David Heidelberger <david.heidelberger(a)ixit.cz> --- diff -Naur a/ui.c b/ui.c --- a/ui.c 2014-01-08 14:00:48.776905827 +0100 +++ b/ui.c 2014-01-08 14:07:51.064903944 +0100 @@ -51,6 +51,9 @@ "\n"\ "iftop, version " IFTOP_VERSION +#define COLOR_SENT 1 +#define COLOR_RECV 2 +#define COLOR_BOTH 3 extern hash_type* history; extern int history_pos; @@ -199,12 +202,13 @@ } } -void draw_bar(float n, int y) { +void draw_bar(float n, int y, short colorpair) { int L; + colorpair = has_colors() ? colorpair : 0; /* set 0 if terminal is not color capable*/ mvchgat(y, 0, -1, A_NORMAL, 0, NULL); L = get_bar_length(8 * n); if (L > 0) - mvchgat(y, 0, L + 1, A_REVERSE, 0, NULL); + mvchgat(y, 0, L + 1, A_REVERSE, colorpair, NULL); } void draw_line_totals(int y, host_pair_line* line, option_linedisplay_t linedisplay) { @@ -219,17 +223,17 @@ if(options.showbars) { switch(linedisplay) { case OPTION_LINEDISPLAY_TWO_LINE: - draw_bar(line->sent[options.bar_interval],y); - draw_bar(line->recv[options.bar_interval],y+1); + draw_bar(line->sent[options.bar_interval],y, COLOR_SENT); + draw_bar(line->recv[options.bar_interval],y+1, COLOR_RECV); break; case OPTION_LINEDISPLAY_ONE_LINE_SENT: - draw_bar(line->sent[options.bar_interval],y); + draw_bar(line->sent[options.bar_interval],y,COLOR_SENT); break; case OPTION_LINEDISPLAY_ONE_LINE_RECV: - draw_bar(line->recv[options.bar_interval],y); + draw_bar(line->recv[options.bar_interval],y,COLOR_RECV); break; case OPTION_LINEDISPLAY_ONE_LINE_BOTH: - draw_bar(line->recv[options.bar_interval] + line->sent[options.bar_interval],y); + draw_bar(line->recv[options.bar_interval] + line->sent[options.bar_interval],y, COLOR_BOTH); break; } } @@ -428,6 +432,13 @@ void ui_curses_init() { (void) initscr(); /* initialize the curses library */ + if (has_colors()) { + start_color(); + use_default_colors(); + init_pair(COLOR_RECV, COLOR_GREEN, -1); + init_pair(COLOR_SENT, COLOR_BLUE, -1); + init_pair(COLOR_BOTH, COLOR_MAGENTA, -1); + } keypad(stdscr, TRUE); /* enable keyboard mapping */ (void) nonl(); /* tell curses not to do NL->CR/NL on output */ (void) cbreak(); /* take input chars one at a time, no wait for \n */

3 7

← Newer
1
2
3
4
5
6
7
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

iftop-users