[tpop3d-discuss]Outlook duplicate messages

Dragos Nitu dragos.nitu at idilis.net
Wed, 26 May 2004 06:09:51 +0200


So far so good. At least there are no side effects. Normal clients still work OK.

Dragos Nitu
Idilis S.A.
Tel: +40-21-2082800
Fax: +40-21-2082801


---------- Original Message -----------
From: Matthew Trent <mtrent@localaccess.com>
To: tpop3d-discuss@lists.beasts.org
Cc: "Dragos Nitu" <dragos.nitu@idilis.net>
Sent: Tue, 25 May 2004 15:52:29 -0700
Subject: Re: [tpop3d-discuss]Outlook duplicate messages

> On Monday 24 May 2004 04:36 pm, Dragos Nitu wrote:
> > OK, thanks. I didn't understand what the problem was about. I made another
> > patch :). This one sure works.
> >
> > In case the connection is closed by the client, and QUIT command is still
> > there, it does apply changes.
> >
> > Because I didn't have an Outlook 2000 to test this, I wrote my own client
> > which doesn't wait for an answer to QUIT, and it works. Behaves just like
> > Outlook.
> >
> > --- tpop3d-1.5.3/netloop.c.orig Mon Nov 24 21:58:28 2003
> > +++ tpop3d-1.5.3/netloop.c      Tue May 25 01:08:39 2004
> > @@ -463,7 +463,17 @@
> >              /* We should now log the closure of the connection and ending
> >               * of any authenticated session. */
> >              if (c->a)
> > +           {
> > +               pop3command p;
> > +               if((p = connection_parsecommand(c)))
> > +                   if(p->cmd == QUIT)
> > +                   {
> > +                       mailbox curmbox;
> > +                       curmbox=c->m;
> > +                       (curmbox)->apply_changes(curmbox);
> > +                   }
> >                  log_print(LOG_INFO, _("connections_post_select: client %s:
> > finished session for `%s' with %s"), c->idstr, c->a->user, c->a->auth);
> > +           }
> >              log_print(LOG_INFO, _("connections_post_select: client %s:
> > disconnected; %d/%d bytes read/written"), c->idstr, c->nrd, c->nwr);
> >
> >  /*            remove_connection(c);*/
> 
> Ok, I've got the patch in place on my servers. So far so good. I'll 
> ask some of the people who have chronic Outlook trouble to let me 
> know if things improve.
> -- 
> Matt
> Systems Administrator
> Local Access Communications
> 360.330.5535
------- End of Original Message -------