[tpop3d-discuss] A few patches

Chris Lightfoot chris at ex-parrot.com
Tue, 15 Jul 2003 00:31:52 +0100

Thanks very much for these. Some of them correct rather
embarrassing errors on my part! I've put the changes into
current CVS.

I need to spend some time fixing up tpo3pd and doing the
1.5.0 release. I'll try to set aside a bit of next weekend
for that. I've been too busy for this lately :(

One (pedantic) comment:

On Mon, Jul 14, 2003 at 11:23:05PM +0200, Yann GROSSEL wrote:
> warnings.diff:
>   removes a few warnings (mainly "missing braces around initializer")
>   (one warning remains at listener.c:59 - I think the alloc_struct
>   macro should be fixed but I don't know the right fix to apply)

The changes relating to struct initialisation aren't
right. For instance, you say

    struct sigaction sa = {{0}};

but you don't actually know that the first element of
struct sigaction is an aggregate type that can be
initialised {0}. `= {0}' is the correct way to initialise
any aggregate `as if in static storage'; gcc rather
unhelpfully produces a warning about it, though. See


``It's clearly a budget. It's got a lot of numbers in it.''
  (George W. Bush)