[tpop3d-discuss] tpop3d-patch

Davi Arnaut davi at hotpop.com
Tue, 11 Feb 2003 12:55:56 -0300


Nice..
Yes, that sleep is not good, we dont want to block auth_mysql..
i will make an configuration option retry_time and fix that..

I also noted that on auth_mysql.c there are two "goto error;"
shouldnt they be "goto fail" ? :)

Davi Arnaut

>
> Excellent. Some comments:
>
> > fork_uid - uid to tpop3d fork as (will not run as root, useful for one
user install, like for mysql)
> > fork_gid - gid o tpop3d fork as
> > auth-mysql-onlogin-delete will execute a delete query, for automatic
cleaning of the user relay table,
> >                                       only the last value will be
keeped.
>
>
>
> > I changed the mysql connection to loop, so if mysql connection fail,
tpop3 will log that to syslog
> > and keep trying to re-connect, but never die.
>
> OK... that's a good idea, but I don't like the way that
> you sleep in auth-mysql. I expect it would be better to
> fail temporarily, and keep re-trying to connect to MySQL.
> I'll have a more detailed look later.
>
> > http://www.verdesmares.com/software.htm
>
> Looks good. I will incorporate these. I should mention
> that the CVS version of tpop3d is not yet `stable for
> production use', though I believe that others are using it
> successfully.
>
> --
> ``The irony of the Information Age is that it has given
>   new respectability to uninformed opinion.'' (John Lawton)