[tpop3d-discuss] Minor errors in tpop3d .. purify is so handy :)

Chris Elsworth chris at shagged.org
Mon, 11 Feb 2002 13:19:25 +0000


Heya.

Not sure if you're too fussed about this, but I've just run tpop3d
through purify on Solaris and found a couple of minor errors - it's
really a testament to the authors that there are only two, so good
work chaps :)

Here's what it did find:

in log_init() in logging.c, line 71, there is an unitialized memory
read. Local variable warn is not explicitly set to anything, so it's
possible that it will be compared with unitialized memory. Simple
resolution - line 57 is the definition and could contain an initial
variable of 0.

Secondly, there's a bit of leaked memory in read_config_file(), in
config.c at line 92. strdup allocates memory via malloc, and purify
reckons there is 21 bytes (told you they were minor errors) being
leaked here - 2 blocks of 5 bytes, 2 blocks of 4 bytes, and a block of
3 bytes.

That's it - just a heads up in case you wanted something to fix :)

-- 
Chris Elsworth  -  Software & Systems Developer  /  Systems Administrator