[tpop3d-discuss] append-domains still working in 1.4.1?

Chris Lightfoot chris at ex-parrot.com
Thu, 25 Apr 2002 20:13:09 +0100


On Thu, Apr 25, 2002 at 02:20:41PM -0500, Christopher E. Stith wrote:
> Thus spake Chris Lightfoot (chris@ex-parrot.com):
> 
> > On Thu, Apr 25, 2002 at 10:35:27AM -0500, Christopher E. Stith wrote:
> > > I'll attach my authenticator just in case anyone wants a look at
> > > some marginal Perl code I wrote the night of my live production
> > > deadline for the first server I had running tpop3d. It authenticates
> > > against a flat file per domain using either traditional crypt()
> > > or MD5 for the password (both actually, and sees if either works).
> > > It allows me to just make a symlink to a directory for overlapping
> > > domains, too. That can come in quite handy.
> > 
> > Thanks for this. Is it OK if I incorporate it into the
> > tpop3d distribution?
> > 
> > I note that you don't return any log messages to the
> > daemon. Is there a problem with uncommenting these?
> 
> Right now, with the new version, I sometimes get an error that
> it is calling an undefined subroutine in my logs. I haven't had
> great amounts of time to track it down, but here's the error:
> 
>     Apr 24 19:46:50 mail tpop3d[2764]: auth_perl_close: error
>     executing perl finish code: ^I(in cleanup) Undefined
>     subroutine &TPOP3D::print_log called at /etc/tpop3d/tpop3d.pl
>     line 72.
> 
> So I've temporarily commented it out. I also have a fix for a

Aargh. Mea culpa. I'd accidentally renamed the subrouting
log_print. This patch should fix it--

Index: auth_perl.c
===================================================================
RCS file: /home/cvs/tpop3d/auth_perl.c,v
retrieving revision 1.22
diff -u -r1.22 auth_perl.c
--- auth_perl.c	2002/03/22 19:37:56	1.22
+++ auth_perl.c	2002/04/25 19:12:23
@@ -63,6 +63,7 @@
     char *file = __FILE__;
     newXS("DynaLoader::boot_DynaLoader", boot_DynaLoader, file);
     newXS("TPOP3D::log_print", xs_log_print, file);
+    newXS("TPOP3D::print_log", xs_log_print, file);
 }
 
 /* auth_perl_init:

> misbehavior of the version I sent. I noticed it was no longer
> handling the case propaerly in which the user sent the full
> address (for example, foo@bar.com) due to the changes in the
> hash provided and the way I changed the authenticator to handle
> that.
> 
> The version attached works both when the domain is and
> when it isn't provided. The conf file is the same.

Cheers.

-- 
Gentlemen! You can't fight in here! This is the War Room!
(from `Dr. Strangelove')