iftop-users October 2011

iftop-users@domain

5 participants
4 discussions

Re: [Iftop-users] Portability to GNU/kFreeBSD
by Mats Erik Andersson 26 Oct '11

26 Oct '11

måndag den 24 oktober 2011 klockan 00:11 skrev Mats Erik Andersson detta: > > First off, renew the four files > > {,config/}config.{guess,sub} > > The present versions are six years old. They are incapable > of working with GNU/kFreeBSD. > > These are necessary changes (variations present also in [1]): > > * The correct conditionals in "addrs_ioctl.c" is > > defined __GLIBC__ & ! defined __linux__ > > in order to catch GNU/kFreeBSD and to avoid NexentaCore. > This MUST be changed, whether or not you decide to ignore > OpenSolaris. I feel compelled to clarify the changes needed to get a valid and buildable support for GNU/kFreeBSD: * config.guess, config.sub, config/config.guess, config/config.sub are outdated and must be renewed. * The patch below must be used to insert correct conditionals. The originals are misconceived. (I am myself to blame for that, but they were sufficient for the Debian package improvements, my original target!) One could argue that defined __GLIBC__ && defined __FreeBSD_kernel__ is even more precise, as it avoids capturing GNU/Hurd, but the check on __GLIBC__ alone is preferred for user land, so __FreeBSD_kernel__ is best avoided. Make an informed choice from this additional points, Mats Erik Andersson, Debian Maintainer (but not for this software) diff -Naur iftop-1.0pre2.orig/addrs_ioctl.c iftop-1.0pre2/addrs_ioctl.c --- iftop-1.0pre2.orig/addrs_ioctl.c 2011-10-02 23:11:30.000000000 +0200 +++ iftop-1.0pre2/addrs_ioctl.c 2011-10-25 11:59:52.000000000 +0200 @@ -19,7 +19,7 @@ #include <netinet/in.h> #if defined __FreeBSD__ || defined __OpenBSD__ || defined __APPLE__ \ - || ( defined __GNUC__ && ! defined __linux__ ) + || ( defined __GLIBC__ && ! defined __linux__ ) #include <sys/param.h> #include <sys/sysctl.h> #include <net/if_dl.h> @@ -81,7 +81,7 @@ } #else #if defined __FreeBSD__ || defined __OpenBSD__ || defined __APPLE__ \ - || ( defined __GNUC__ && ! defined __linux__ ) + || ( defined __GLIBC__ && ! defined __linux__ ) { int sysctlparam[6] = {CTL_NET, PF_ROUTE, 0, 0, NET_RT_IFLIST, 0}; size_t needed = 0;

2 2

[Iftop-users] Portability to GNU/kFreeBSD and OpenSolaris
by Mats Erik Andersson 23 Oct '11

23 Oct '11

Clearly no-one listened to my portability suggestions in [1]. Let me therefore point out changes mandatory to 1.0pre2, should you desire to support the OpenSolaris variant known as NexentaCore. Two changes are also relevant for GNU/kFreeBSD. First off, renew the four files {,config/}config.{guess,sub} The present versions are six years old. They are incapable of working with GNU/kFreeBSD. These are necessary changes (variations present also in [1]): * The correct conditionals in "addrs_ioctl.c" is defined __GLIBC__ & ! defined __linux__ in order to catch GNU/kFreeBSD and to avoid NexentaCore. This MUST be changed, whether or not you decide to ignore OpenSolaris. * OpenSolaris does _not_ contain any "<sys/sysctl.h>" Exclude it"! * OpenSolaris _must_ test HAVE_SYS_SOCKIO_H and then include "<sys/sockio.h>". * You can not declare sigalrm() as non-static, and then define sigalrm() as static. That leads to compiler error, unless you ignore sanity checking. * OpenSolaris can not rely on "<curses.h>", since the 32-bit calls are only present in "<ncurses.h>". I demonstrated in [1] a functional technique to let the configuration script adapt to whatever Curses compatible library happens to be available in five different operating systems. Implement that method, or use the shortcut shown below. Make your choice, I have given the options. Mats Erik Andersson [1] http://lists.beasts.org/pipermail/iftop-users/2011-August/000344.html diff -Naur iftop-1.0pre2.orig/addrs_ioctl.c iftop-1.0pre2/addrs_ioctl.c --- iftop-1.0pre2.orig/addrs_ioctl.c 2011-10-02 23:11:30.000000000 +0200 +++ iftop-1.0pre2/addrs_ioctl.c 2011-10-23 23:33:41.777439591 +0200 @@ -19,12 +19,18 @@ #include <netinet/in.h> #if defined __FreeBSD__ || defined __OpenBSD__ || defined __APPLE__ \ - || ( defined __GNUC__ && ! defined __linux__ ) + || ( defined __GLIBC__ && ! defined __linux__ ) #include <sys/param.h> +# if !__sun__ #include <sys/sysctl.h> +# endif #include <net/if_dl.h> #endif +#if HAVE_SYS_SOCKIO_H +# include <sys/sockio.h> +#endif + #ifdef USE_GETIFADDRS #include <ifaddrs.h> #endif @@ -81,7 +87,7 @@ } #else #if defined __FreeBSD__ || defined __OpenBSD__ || defined __APPLE__ \ - || ( defined __GNUC__ && ! defined __linux__ ) + || ( defined __GLIBC__ && ! defined __linux__ ) { int sysctlparam[6] = {CTL_NET, PF_ROUTE, 0, 0, NET_RT_IFLIST, 0}; size_t needed = 0; diff -Naur iftop-1.0pre2.orig/dlcommon.c iftop-1.0pre2/dlcommon.c --- iftop-1.0pre2.orig/dlcommon.c 2003-06-07 00:42:34.000000000 +0200 +++ iftop-1.0pre2/dlcommon.c 2011-10-23 23:19:48.803230766 +0200 @@ -462,7 +462,7 @@ err("dlphysaddrack: short response ctl.len: %d", ctl.len); } -static void +void sigalrm() { (void) err("sigalrm: TIMEOUT"); diff -Naur iftop-1.0pre2.orig/options.c iftop-1.0pre2/options.c --- iftop-1.0pre2.orig/options.c 2011-10-04 22:39:42.000000000 +0200 +++ iftop-1.0pre2/options.c 2011-10-23 23:07:20.794488198 +0200 @@ -19,6 +19,10 @@ #include <arpa/inet.h> #include <net/if.h> +#if HAVE_SYS_SOCKIO_H +# include <sys/sockio.h> +#endif + #include "iftop.h" #include "options.h" #include "cfgfile.h" diff -Naur iftop-1.0pre2.orig/ui.c iftop-1.0pre2/ui.c --- iftop-1.0pre2.orig/ui.c 2011-10-03 22:30:03.000000000 +0200 +++ iftop-1.0pre2/ui.c 2011-10-23 23:21:11.527269307 +0200 @@ -6,7 +6,11 @@ #include <sys/types.h> #include <ctype.h> -#include <curses.h> +#ifdef __sun__ +# include <ncurses.h> +#else +# include <curses.h> +#endif #include <errno.h> #include <string.h> #include <math.h>

1 0

[Iftop-users] Monitoring all traffic
by joedson marques 21 Oct '11

21 Oct '11

Hello Guys, I have the scenario following: One freeBSD that works as router, so, most of the traffic that pass through an interface is not connection, but just packages that are being routed. I wanna monitoring all traffic passing through an interface, no just the traffic generated by connections. Is possible make this monitoring without change the source code of the iftop? If not, which part of source code should I change? Thanks!

3 7

[Iftop-users] iftop 1.0pre2
by Paul Warren 04 Oct '11

04 Oct '11

After an unreasonably long delay, I've finally got round to releasing iftop-1.0pre2. Hopefully this fixes compilation issues on various platforms, including FreeBSD and Mac OS X. It's also got: * reverse IPv6 using all methods except ares * faster switching of graph scale * fixed support for DLT_NULL * fix for segfault on interfaces with no MAC address * improved interface autodetect * a stab at implementing support for radiotap interfaces (DLT 127). Specific items I'm looking for feedback on: * Does it compile? If you could drop me an off-list email with platforms that you've tested on, that would be useful. * Does anyone still use the ares resolver implementation? * Does the interface autodetection work any better or worse than 1.0pre1 or earlier? (i.e. do you get the interface you expected when run with no options) I hope I've dealt with all the patches I've received since 1.0pre1. If you've sent me a patch and I've not acknowledged it, please let me know. Barring any serious issues, I hope to push this to 1.0 soon. It's getting close to iftop's 10th anniversary, so it's probably about time :-) Paul

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

iftop-users October 2011