From g.roest at grepit.nl  Sat Nov 21 18:43:35 2009
From: g.roest at grepit.nl (Gerben Roest)
Date: Sat, 21 Nov 2009 19:43:35 +0100
Subject: [Iftop-users] typo patch
Message-ID: <4B0834D7.9090504@grepit.nl>

This is a multi-part message in MIME format.
--------------090407030203050509060208
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi,

cummulative should be cumulative, and kilobytes should be kB, not KB.

greetings,

Gerben

--------------090407030203050509060208
Content-Type: text/x-diff;
 name="cumm-kB.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cumm-kB.patch"

*** ui.c	2005-10-26 22:12:33.000000000 +0200
--- ../iftop-0.17-modified/ui.c	2009-11-21 17:57:32.000000000 +0100
***************
*** 40,42 ****
  " t - cycle line display mode            B - cycle bar graph average\n"\
! "                                        T - toggle cummulative line totals\n"\
  "Port display:                           j/k - scroll display\n"\
--- 40,42 ----
  " t - cycle line display mode            B - cycle bar graph average\n"\
! "                                        T - toggle cumulative line totals\n"\
  "Port display:                           j/k - scroll display\n"\
***************
*** 60,63 ****
  #define UNIT_DIVISIONS 4
! char* unit_bits[UNIT_DIVISIONS] =  { "b", "Kb", "Mb", "Gb"};
! char* unit_bytes[UNIT_DIVISIONS] =  { "B", "KB", "MB", "GB"};
  
--- 60,63 ----
  #define UNIT_DIVISIONS 4
! char* unit_bits[UNIT_DIVISIONS] =  { "b", "kb", "Mb", "Gb"};
! char* unit_bytes[UNIT_DIVISIONS] =  { "B", "kB", "MB", "GB"};
  
***************
*** 695,697 ****
      /* Cummulative totals */
!     mvaddstr(y, 16, "cumm: ");
  
--- 695,697 ----
      /* Cummulative totals */
!     mvaddstr(y, 16, "cum: ");
  
***************
*** 1084,1089 ****
                  if(options.show_totals) {
!                     showhelp("Show cummulative totals");
                  }
                  else {
!                     showhelp("Hide cummulative totals");
                  }
--- 1084,1089 ----
                  if(options.show_totals) {
!                     showhelp("Show cumulative totals");
                  }
                  else {
!                     showhelp("Hide cumulative totals");
                  }

--------------090407030203050509060208--


From pdw at ex-parrot.com  Sat Nov 21 19:31:02 2009
From: pdw at ex-parrot.com (Paul Warren)
Date: Sat, 21 Nov 2009 19:31:02 +0000
Subject: [Iftop-users] typo patch
In-Reply-To: <4B0834D7.9090504@grepit.nl>
References: <4B0834D7.9090504@grepit.nl>
Message-ID: <98773F77-C2F4-4BE6-93EC-D86756468C09@ex-parrot.com>

Gerben,

That's the kind of bug report I like to receive :-)

Now committed in CVS.

thanks,

Paul

On 21 Nov 2009, at 18:43, Gerben Roest wrote:

> Hi,
>
> cummulative should be cumulative, and kilobytes should be kB, not KB.
>
> greetings,
>
> Gerben
> *** ui.c	2005-10-26 22:12:33.000000000 +0200
> --- ../iftop-0.17-modified/ui.c	2009-11-21 17:57:32.000000000 +0100
> ***************
> *** 40,42 ****
>  " t - cycle line display mode            B - cycle bar graph average 
> \n"\
> ! "                                        T - toggle cummulative  
> line totals\n"\
>  "Port display:                           j/k - scroll display\n"\
> --- 40,42 ----
>  " t - cycle line display mode            B - cycle bar graph average 
> \n"\
> ! "                                        T - toggle cumulative  
> line totals\n"\
>  "Port display:                           j/k - scroll display\n"\
> ***************
> *** 60,63 ****
>  #define UNIT_DIVISIONS 4
> ! char* unit_bits[UNIT_DIVISIONS] =  { "b", "Kb", "Mb", "Gb"};
> ! char* unit_bytes[UNIT_DIVISIONS] =  { "B", "KB", "MB", "GB"};
>
> --- 60,63 ----
>  #define UNIT_DIVISIONS 4
> ! char* unit_bits[UNIT_DIVISIONS] =  { "b", "kb", "Mb", "Gb"};
> ! char* unit_bytes[UNIT_DIVISIONS] =  { "B", "kB", "MB", "GB"};
>
> ***************
> *** 695,697 ****
>      /* Cummulative totals */
> !     mvaddstr(y, 16, "cumm: ");
>
> --- 695,697 ----
>      /* Cummulative totals */
> !     mvaddstr(y, 16, "cum: ");
>
> ***************
> *** 1084,1089 ****
>                  if(options.show_totals) {
> !                     showhelp("Show cummulative totals");
>                  }
>                  else {
> !                     showhelp("Hide cummulative totals");
>                  }
> --- 1084,1089 ----
>                  if(options.show_totals) {
> !                     showhelp("Show cumulative totals");
>                  }
>                  else {
> !                     showhelp("Hide cumulative totals");
>                  }