[Iftop-users] iftop: scaling, 1024 base, patch

Aidas Kasparas a.kasparas at gmc.lt
Mon, 14 Nov 2005 17:23:49 +0200


This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_sizifas.gmc.lt-29274-1131981830-0001-2
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hello,

	iftop is fantastic tool! Thanks for it.

	On the other hand, I found little strange when it's scale ends at 977kb
with traffic in the ranges 256+ .. ~1000 kb and then jumps right to
9.54Mb. If someone has 1-1.5Mbit (and I'm one of such), then suddenly
all the graphs become very small. I tried to add more steps and at the
same time move to base 1024.

	Attached patch solves these problems. Unfortunately, I had no setup to
test correctness of this patch for speeds above 2Mbps.

-- 
Aidas Kasparas
IT administrator
GM Consult Group, UAB

--=_sizifas.gmc.lt-29274-1131981830-0001-2
Content-Type: text/plain; name="1024.diff"; charset=iso-8859-1
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="1024.diff"

LS0tIGlmdG9wLTAuMTYub3JpZy91aS5jCisrKyBpZnRvcC0wLjE2L3VpLmMKQEAgLTE2OSw3
ICsxNjksNyBAQAogICAgIH0KIAogICAgIHdoaWxlKDEpIHsKLSAgICAgIGlmKG4gPCBzaXpl
ICogMTAwMCB8fCBpID49IFVOSVRfRElWSVNJT05TIC0gMSkgeworICAgICAgaWYobiA8IHNp
emUgKiAxMDI0IHx8IGkgPj0gVU5JVF9ESVZJU0lPTlMgLSAxKSB7CiAgICAgICAgIHNucHJp
bnRmKGJ1ZiwgYnNpemUsICIgJTQuMGYlcyIsIG4gLyBzaXplLCBieXRlcyA/IHVuaXRfYnl0
ZXNbaV0gOiB1bml0X2JpdHNbaV0pOyAKICAgICAgICAgYnJlYWs7CiAgICAgICB9CkBAIC0x
OTEsMTkgKzE5MSwyNiBAQAogc3RhdGljIHN0cnVjdCB7CiAgICAgaW50IG1heCwgaW50ZXJ2
YWw7CiB9IHNjYWxlW10gPSB7Ci0gICAgICAgIHsgICAgICA2NDAwMCwgICAgIDEwIH0sICAg
ICAvKiA2NCBrYml0L3MgKi8KLSAgICAgICAgeyAgICAgMTI4MDAwLCAgICAgMTAgfSwKLSAg
ICAgICAgeyAgICAgMjU2MDAwLCAgICAgMTAgfSwKLSAgICAgICAgeyAgICAxMDAwMDAwLCAg
ICAgMTAgfSwgICAgIC8qIDEgTWJpdC9zICovCi0gICAgICAgIHsgICAxMDAwMDAwMCwgICAg
IDEwIH0sICAgICAKLSAgICAgICAgeyAgMTAwMDAwMDAwLCAgICAxMDAgfSwKLSAgICAgICAg
eyAxMDAwMDAwMDAwLCAgICAxMDAgfSAgICAgIC8qIDEgR2JpdC9zICovCisgICAgICAgIHsg
ICAgICAgICAgNjQgKiAxMDI0LCAgICAgMTAgfSwgICAgIC8qIDY0IGtiaXQvcyAqLworICAg
ICAgICB7ICAgICAgICAgMTI4ICogMTAyNCwgICAgIDEwIH0sCisgICAgICAgIHsgICAgICAg
ICAyNTYgKiAxMDI0LCAgICAgMTAgfSwKKyAgICAgICAgeyAgICAgICAgIDUxMiAqIDEwMjQs
ICAgICAxMCB9LAorICAgICAgICB7ICAgICAgICAxMDI0ICogMTAyNCwgICAgIDEwIH0sICAg
ICAvKiAxIE1iaXQvcyAqLworICAgICAgICB7ICAgIDIgKiAxMDI0ICogMTAyNCwgICAgIDEw
IH0sICAgICAKKyAgICAgICAgeyAgICA1ICogMTAyNCAqIDEwMjQsICAgICAxMCB9LCAgICAg
CisgICAgICAgIHsgICAxMCAqIDEwMjQgKiAxMDI0LCAgICAgMTAgfSwgICAgIAorICAgICAg
ICB7ICAgMjAgKiAxMDI0ICogMTAyNCwgICAgIDEwIH0sICAgICAKKyAgICAgICAgeyAgIDUw
ICogMTAyNCAqIDEwMjQsICAgICAxMCB9LCAgICAgCisgICAgICAgIHsgIDEwMCAqIDEwMjQg
KiAxMDI0LCAgICAxMDAgfSwgICAgIAorICAgICAgICB7ICAyMDAgKiAxMDI0ICogMTAyNCwg
ICAgMTAwIH0sICAgICAKKyAgICAgICAgeyAgNTAwICogMTAyNCAqIDEwMjQsICAgIDEwMCB9
LCAgICAgCisgICAgICAgIHsgMTAyNCAqIDEwMjQgKiAxMDI0LCAgICAxMDAgfSAgICAgIC8q
IDEgR2JpdC9zICovCiAgICAgfTsKIHN0YXRpYyBpbnQgcmF0ZWlkeCA9IDAsIHdhbnRiaWdn
ZXJyYXRlOwogCiBzdGF0aWMgaW50IGdldF9iYXJfaW50ZXJ2YWwoZmxvYXQgYmFuZHdpZHRo
KSB7CiAgICAgaW50IGkgPSAxMDsKLSAgICBpZihiYW5kd2lkdGggPiAxMDAwMDAwMDApIHsK
KyAgICBpZihiYW5kd2lkdGggPiAxMDAgKiAxMDI0ICogMTAyNCkgewogICAgICAgICBpID0g
MTAwOwogICAgIH0KICAgICByZXR1cm4gaTsK
--=_sizifas.gmc.lt-29274-1131981830-0001-2--