[Iftop-users] Segfault on Fedora

Chris Lightfoot chris at ex-parrot.com
Fri, 19 Mar 2004 09:39:02 +0000


On Fri, Mar 19, 2004 at 10:16:24AM +0100, richard lucassen wrote:
> On Thu, 18 Mar 2004 21:59:37 +0000
> Paul Warren <pdw@ex-parrot.com> wrote:
> 
> > > The iftoprc is included in the tarball. But even if there is rubbish
> > > in the file, iftop should not segfault IMHO ;-)
> > 
> > This is true. 
> > 
> > The iftop you're running doesn't appear to have debugging info in it,
> > so I can't tell much from the bt.  Can you recompile with debugging
> > info. I think "CFLAGS=-g && make clean && make" should do the trick.
> > 
> > Please just cut and paste the trace into the email - I'll respond
> > quicker that way :-)
> 
> Ok, here it is:
> 
> #1  0x0804e456 in is_cfgdirective_valid (s=0x96ce178 "port-resolution")
>     at cfgfile.c:50

-- could you try this patch?

diff -u -r1.4 cfgfile.c
--- cfgfile.c   4 Nov 2003 11:57:45 -0000       1.4
+++ cfgfile.c   19 Mar 2004 09:38:34 -0000
@@ -45,9 +45,9 @@
 extern options_t options ;
 
 int is_cfgdirective_valid(const char *s) {
-    char* t;
-    for (t = config_directives[0]; t != NULL; ++t)
-        if (strcmp(s, t) == 0) return 1;
+    char **t;
+    for (t = config_directives; t != NULL; ++t)
+        if (strcmp(s, *t) == 0) return 1;
     return 0;
 }
 


-- 
``While you're waiting, read the free novel we sent you.
  It's a Spanish story about a guy named `Manual'.'' (from `Dilbert')